Sync Speedrun with last version Scaffold Stark #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadai2010
changed the title
iossocket
reviewed
Nov 20, 2024
| @@ -28,7 +28,7 @@ export function getBlockExplorerTxLink(network: string, txnHash: string) { | |||
|
|
|||
| const targetChainArr = chainNames.filter((chainName) => { | |||
| const wagmiChain = chains[chainName as keyof typeof chains]; | |||
| return wagmiChain.network === network; | |||
| return (wagmiChain as { network: string }).network === network; | |||
There was a problem hiding this comment.
can change the import way and update the chains.Chain to Chain in this file
// import * as chains from "@starknet-react/chains";
import { devnet, sepolia, mainnet, Chain } from "@starknet-react/chains";
export const chains = {
devnet,
sepolia,
mainnet,
};
There was a problem hiding this comment.
Great, thank you very much for the contribution.
metalboyrick
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with last version Scaffold Stark
Issue #162 resolved, once the new changes are in Scaffold Stark merged (PR-355, PR-353) , I will add them and we will review them
Types of change
Comments (optional)